Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few npm dependencies #10761

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Update a few npm dependencies #10761

merged 2 commits into from
Sep 6, 2022

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Sep 6, 2022

Updates a few outdated npm dependencies as per steps outlined in the Release guide. Reviewing the release notes, these packages have no significant changes based on our usage to report in CHANGES.md.

jsep, lerc, and several dev dependency updates require further changes and will be done in a follow-up PR.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests and spot tested Sandcastles. Everything looks good. Thanks @ggetz!

@sanjeetsuhag sanjeetsuhag merged commit 289aaae into main Sep 6, 2022
@sanjeetsuhag sanjeetsuhag deleted the update-npm branch September 6, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

3 participants